Postgres Pro
Downloads
Home   >   mailing lists

Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS - Mailing list pgsql-hackers

From Tatsuro Yamada
Subject Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Date
Msg-id 57f271ca-b943-901e-0f56-0862b787b8b2@lab.ntt.co.jp
Whole thread Raw
In response to Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 2018/12/26 13:50, Michael Paquier wrote:
> On Tue, Dec 25, 2018 at 02:27:03PM +0900, Michael Paquier wrote:
>> Thanks, I have committed this one after making the logic to ignore
>> column numbers a bit smarter, one problem being that "ALTER INDEX foo
>> ALTER COLUMN" would try to suggest SET STATISTICS directly, which is
>> incorrect.  Instead I have tweaked the completion so as COLUMN is
>> added after "ALTER INDEX foo ALTER".  This could be completed later
>> with the column numbers, in a way similar to what ALTER TABLE does.
> 
> Could you rebase the latest patch please?  The latest version sent
> does not apply anymore:
> [1]: https://www.postgresql.org/message-id/bcecaf0e-ab92-8271-6887-da213aea9dac@lab.ntt.co.jp
> --
> Michael

Do you mean my "fix_manual_of_alter_index_v2.patch"?
It is able to patch on f89ae34ab8b4d9e9ce8af6bd889238b0ccff17cb like this:

=====
$ patch -p1 < fix_manual_of_alter_index_v2.patch
patching file doc/src/sgml/ref/alter_index.sgml
=====

Thanks,
Tatsuro Yamada

pgsql-hackers by date:

Previous
From: Tatsuro Yamada
Date:
Subject: Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS
Next
From: Michael Paquier
Date:
Subject: Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements