> On 1 Apr 2022, at 12:46, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> + if (len >= sizeof(dstpath))
>> + pg_fatal("filepath buffer too small"); /* shouldn't happen */
>
> Makes sense. I would remove the "shouldn't happen"; it's not very hard to make it happen, you just need a very long
targetdatadir path. And rephrase the error message as "datadir path too long".
Right, good point.
> One typo in the commit message: s/update/updates/.
Will fix.
--
Daniel Gustafsson https://vmware.com/
