Re: recovery starting when backup_label exists, but notrecovery.signal - Mailing list pgsql-hackers

From David Steele
Subject Re: recovery starting when backup_label exists, but notrecovery.signal
Date
Msg-id 576ee0e4-bc21-291b-d1e3-db11b4edba43@pgmasters.net
Whole thread Raw
In response to Re: recovery starting when backup_label exists, but notrecovery.signal  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Hi Peter,

On 9/27/19 3:35 PM, Peter Eisentraut wrote:
> On 2019-09-27 10:34, Fujii Masao wrote:
>>> Also, are you sure this is a new behavior?
>> In v11 or before, if backup_label exists but not recovery.conf,
>> the startup process doesn't enter an archive recovery mode. It starts
>> crash recovery in that case. So the bahavior is somewhat different
>> between versions.
> 
> Can you bisect this?  I have traced through xlog.c in both versions and
> I don't see how this logic is any different in any obvious way.

What I've been seeing is that the underlying logic isn't different but
there are more ways to get into it.

Previously, there was no archive/targeted recovery without
recovery.conf, but now there are several ways to get to archive/targeted
recovery, i.e., making the recovery settings GUCs has bypassed controls
that previously had limited how they could be used and when.

The issues on the other thread [1], at least, were all introduced in
2dedf4d9.

Regards,
-- 
-David
david@pgmasters.net

[1]
https://www.postgresql.org/message-id/flat/e445616d-023e-a268-8aa1-67b8b335340c%40pgmasters.net



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensureclean shutdown)
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] "may be unused" warnings for gcc