Re: COPY (... tab completion - Mailing list pgsql-hackers

From Andreas Karlsson
Subject Re: COPY (... tab completion
Date
Msg-id 569D89E4.6090008@proxel.se
Whole thread Raw
In response to Re: COPY (... tab completion  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: COPY (... tab completion  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On 01/11/2016 02:01 AM, Peter Eisentraut wrote:
> I think this would be a useful addition.  A couple of problems:

Thanks for the review. A new version is attached.

> This change in the comment doesn't make sense to me and doesn't seem to
> match the code:
>
> -    /* If we have COPY [BINARY] <sth>, complete it with "TO" or "FROM" */
> +    /* If we have COPY|BINARY <sth>, complete it with "TO" or "FROM" */

Fixed. As Tom correctly guessed this was the result of a mistake when
rebasing.

> The list of commands to allow as the "query" inside the parentheses is
> documented to be: SELECT, VALUES, INSERT, UPDATE or DELETE; and actually
> TABLE should also work.  Your list doesn't include all of those.  So
> please adjust that.

Fixed. And TABLE works too.

Andreas

Attachment

pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Interesting read on SCM upending software and hardware architecture
Next
From: Andreas Karlsson
Date:
Subject: Re: COPY (... tab completion