Hi,
On 12/07/2015 03:47 PM, Stas Kelvich wrote:
> Hello, fixed.
I've looked at the patch today, seems mostly fine to me.
Three comments though:
1) (nitpicking) There seem to be some minor whitespace issues, i.e. trailing spaces, empty lines being added/removed,
etc.
2) one of the regression tests started to fail
SELECT '-1e-700'::cube AS cube;
This used to return (0) but now I get (-0). As this query existed in 1.0, it's probably due to change in the C
code.Now sure where.
3) I wonder why the docs were changed like this:
<para>
- It does not matter which order the opposite corners of a cube are
- entered in. The <type>cube</> functions
- automatically swap values if needed to create a uniform
- <quote>lower left — upper right</> internal representation.
+ When corners coincide cube stores only one corner along with a special flag in order to reduce size wasted.
</para>
Was the old behavior removed? I don't think so - it seems to behave as before, so why to remove this information?
Maybeit's not useful? But then why add the bit about optimizing storage of points?
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
