Re: Fwd: [GENERAL] pgxs/config/missing is... missing - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: Fwd: [GENERAL] pgxs/config/missing is... missing
Date
Msg-id 566B6979.7030701@BlueTreble.com
Whole thread Raw
In response to Re: Fwd: [GENERAL] pgxs/config/missing is... missing  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fwd: [GENERAL] pgxs/config/missing is... missing  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
On 12/10/15 7:09 PM, Tom Lane wrote:
> Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
>> AFAICT the problem is that missing wasn't included in install or
>> uninstall in config/Makefile. Attached patch fixes that, and results in
>> missing being properly installed in lib/pgxs/config.
>
> I thought we'd more or less rejected that approach in the previous thread.

David Wheeler and I worked on a way to work around this in the pgTap 
extension, but AFAICT there's a bug here. The FreeBSD packages seems to 
be built without having PERL on the system, so if you try and use it 
with PGXS to set PERL, you end up with

PERL = /bin/sh
/usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl

which is coming out of the PGXS makefile. And that would work fine, if 
we were actually installing config/missing.

If instead of installing config/missing we want to just drop that file 
completely we can do that, but then we should remove it from sorce and 
from the makefiles.
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Add IS (NOT) DISTINCT to subquery_Op
Next
From: Tom Lane
Date:
Subject: Re: Bootstrap DATA is a pita