On 12/11/15 6:25 PM, Jim Nasby wrote:
> On 12/10/15 7:09 PM, Tom Lane wrote:
>> Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
>>> AFAICT the problem is that missing wasn't included in install or
>>> uninstall in config/Makefile. Attached patch fixes that, and results in
>>> missing being properly installed in lib/pgxs/config.
>>
>> I thought we'd more or less rejected that approach in the previous
>> thread.
>
> David Wheeler and I worked on a way to work around this in the pgTap
> extension, but AFAICT there's a bug here. The FreeBSD packages seems to
> be built without having PERL on the system, so if you try and use it
> with PGXS to set PERL, you end up with
>
> PERL = /bin/sh
> /usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl
>
> which is coming out of the PGXS makefile. And that would work fine, if
> we were actually installing config/missing.
>
> If instead of installing config/missing we want to just drop that file
> completely we can do that, but then we should remove it from sorce and
> from the makefiles.
Grr, right after sending this I found the thread you were talking about.
I'm not really sure our missing is better than just letting the error
bubble up. If folks think that's better then lets just rip missing out
entirely.
If we do decide to keep missing, we should probably clarify it's
messages to indicate that the relevant file was missing when *configure
was run*.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
