Re: [PROPOSAL] TAP test example - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: [PROPOSAL] TAP test example
Date
Msg-id 564DED3D.7000004@BlueTreble.com
Whole thread Raw
In response to [PROPOSAL] TAP test example  (Nikolay Shaplov <n.shaplov@postgrespro.ru>)
Responses Re: [PROPOSAL] TAP test example  (Nikolay Shaplov <n.shaplov@postgrespro.ru>)
List pgsql-hackers
On 11/19/15 8:42 AM, Nikolay Shaplov wrote:
> +sub psql_ok
> +{
> +    my $db = shift;
> +    my $sql = shift;
> +    my $comment = shift;

Isn't the preferred method of parameter assignment to use @_?

Also, I'd think one of the examples should use DBI, since presumably one 
of the big benefits to tap is not dealing with raw psql output...
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: proposal: LISTEN *
Next
From: Nikolay Shaplov
Date:
Subject: Re: [PROPOSAL] TAP test example