Re: A bug when use get_bit() function for a long bytea string - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A bug when use get_bit() function for a long bytea string
Date
Msg-id 563.1585857846@sss.pgh.pa.us
Whole thread Raw
In response to Re: A bug when use get_bit() function for a long bytea string  ("Daniel Verite" <daniel@manitou-mail.org>)
Responses Re: A bug when use get_bit() function for a long bytea string
List pgsql-hackers
"Daniel Verite" <daniel@manitou-mail.org> writes:
> These 2 tests need to allocate big chunks of contiguous memory, so they
> might fail for lack of memory on tiny machines, and even when not failing,
> they're pretty slow to run. Are they worth the trouble?

Yeah, I'd noticed those on previous readings of the patch.  They'd almost
certainly fail on some of our older/smaller buildfarm members, so they're
not getting committed, even if they didn't require multiple seconds apiece
to run (even on a machine with plenty of memory).  It's useful to have
them for initial testing though.

It'd be great if there was a way to test get_bit/set_bit on large
indexes without materializing a couple of multi-hundred-MB objects.
Can't think of one offhand though.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: backup manifests
Next
From: Peter Geoghegan
Date:
Subject: Re: snapshot too old issues, first around wraparound and then more.