Re: ATT_FOREIGN_TABLE and ATWrongRelkindError() - Mailing list pgsql-hackers

From Amit Langote
Subject Re: ATT_FOREIGN_TABLE and ATWrongRelkindError()
Date
Msg-id 562D8C25.1070109@lab.ntt.co.jp
Whole thread Raw
In response to Re: ATT_FOREIGN_TABLE and ATWrongRelkindError()  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: ATT_FOREIGN_TABLE and ATWrongRelkindError()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2015/10/23 19:02, Amit Langote wrote:
> On 2015/10/23 18:51, Etsuro Fujita wrote:
>>
>> This is really really nitpicking, but I noticed that there is an implicit
>> rule concerning the message format in ATWrongRelkindError; if more than
>> two objects are present, the message is "\"%s\" is not a foo, bar, or
>> baz". ("or" is preceded by a comma!)  So, would it be better that the
>> former is "\"%s\" is not a table, view, or foreign table"?
>
> Oops! Yeah, I missed the comma there. That seems like a generally
> preferred punctuation rule (the comma before conjunction(s) I mean).

Here is a patch rectifying that mistake.

Thanks,
Amit

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: questions about PG update performance
Next
From: Tomas Vondra
Date:
Subject: Re: pgbench gaussian/exponential docs improvements