Re: Statistics Import and Export - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Statistics Import and Export
Date
Msg-id 560cca3781740bd69881bb07e26eb8f65b09792c.camel@j-davis.com
Whole thread Raw
In response to Re: Statistics Import and Export  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Statistics Import and Export
List pgsql-hackers
On Mon, 2025-02-24 at 15:03 -0500, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
> > But you have a point in that float4in() does slightly more work
> > than
> > strtof() to handle platform differences about NaN/Inf. I'm not sure
> > how
> > much to weigh that concern, but I agree that there is non-zero
> > cognitive overhead here.
>
> If we're speaking strictly about the reltuples value, I'm not hugely
> concerned about that.  reltuples should never be NaN or Inf.

There actually is a concern here, in that the backend always has
LC_NUMERIC=C when doing float4in/out, but pg_dump does not. Patch
attached.

Regards,
    Jeff Davis


Attachment

pgsql-hackers by date:

Previous
From: "Devulapalli, Raghuveer"
Date:
Subject: RE: Improve CRC32C performance on SSE4.2
Next
From: Andres Freund
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER