> The comment change was correct, but the condition used &&. Should've been ||.
> There is another copy of basically the same condition earlier in the function
> that was changed correctly, but I blundered this one. Oops.
>
> The attached patch fixes this. I also added an assertion to the
> gistplacetopage() function, to check that we never try to insert on a deleted
> page. This bug could've made that happen too, although in this case the problem
> was a concurrent split, not a deletion. I'll backpatch and push this tomorrow.
>
> Many thanks for the easy reproducer script, Duncan!
No problem Heikki, thanks for the quick fix.
Best wishes, Duncan.
