Review: GiST support for UUIDs - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Review: GiST support for UUIDs
Date
Msg-id 55F6EE82.8080209@sigaev.ru
Whole thread Raw
Responses Re: Review: GiST support for UUIDs  (Andres Freund <andres@anarazel.de>)
Re: Review: GiST support for UUIDs  (Paul Jungwirth <pj@illuminatedcomputing.com>)
List pgsql-hackers
http://www.postgresql.org/message-id/flat/CA+renyVepHxTO1c7dFbVjP1GYMUc0-3qDNWPN30-noo5MPyaVQ@mail.gmail.com#CA+renyVepHxTO1c7dFbVjP1GYMUc0-3qDNWPN30-noo5MPyaVQ@mail.gmail.com

Patch looks perfect but it's still needed some work.

0) rebase to current HEAD (done, in attach)
1) UUIDSIZE ->  UUID_LEN (it's defined in utils/uuid.h, done)
2)
    static double
    uuid2num(const pg_uuid_t *i)
    {
        return *((uint64 *)i);
    }
    It isn't looked as correct transformation for me. May be, it's better
    to transform to numeric type (UUID looks like a 16-digit hexademical number)
    and follow  gbt_numeric_penalty() logic (or even call directly).




--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics
Next
From: Andres Freund
Date:
Subject: Re: Review: GiST support for UUIDs