Re: [PATCH] Microvacuum for gist. - Mailing list pgsql-hackers

Some notices

1 gistvacuumpage():    OffsetNumber deletable[MaxOffsetNumber];  Seems, MaxOffsetNumber is too much,
MaxIndexTuplesPerPageis enough
 

2 Loop in gistkillitems() for searching heap pointer. It seems to me that
it could be a performance problem. To fix it, it's needed to remember index 
tuple's offset number somewhere near GISTScanOpaqueData->killedItems. And
gistkillitems() will loop over offsets and compare heap pointer from killedItems 
and index tuple, if they doesn't match then just skip this index tuple.

3 Connected with previous, could you show some performance tests?


-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/