Re: Warnings around booleans - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Warnings around booleans
Date
Msg-id 55CC846E.6030001@iki.fi
Whole thread Raw
In response to Warnings around booleans  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 08/13/2015 02:41 PM, Andres Freund wrote:
> On 2015-08-13 14:28:58 +0300, Heikki Linnakangas wrote:
>> On 08/12/2015 03:46 PM, Stephen Frost wrote:
>>> * Andres Freund (andres@anarazel.de) wrote:
>>>> On 2015-08-12 08:16:09 -0400, Stephen Frost wrote:
>>>>>> 1) gin stores/queries some bools as GinTernaryValue.
>>>>>>
>>>>>>     Part of this is easy to fix, just adjust GinScanKeyData->entryRes to
>>>>>>     be a GinTernaryValue (it's actually is compared against
>>>>>>     MAYBE).
>
> That bit looks sane to you? That appears to be an actual misdeclaration
> to me.

Yeah, changing entryRes to GinTernaryValue seems good to me.

- Heikki




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Warnings around booleans
Next
From: Kouhei Kaigai
Date:
Subject: Re: [DESIGN] ParallelAppend