Re: clarify "rewritten" in pg_checksums docs - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: clarify "rewritten" in pg_checksums docs
Date
Msg-id 55BA957E-9C2B-4781-B78D-36987ACBB611@yesql.se
Whole thread Raw
In response to Re: clarify "rewritten" in pg_checksums docs  (Michael Banck <michael.banck@credativ.de>)
Responses Re: clarify "rewritten" in pg_checksums docs
List pgsql-hackers
> On 1 Sep 2020, at 15:34, Michael Banck <michael.banck@credativ.de> wrote:
> Am Dienstag, den 01.09.2020, 15:29 +0200 schrieb Daniel Gustafsson:

>> Isn't "modified in-place" a more accurate description of the process?
> 
> AIUI we do rewrite the whole file (block by block, after updating the
> page header with the checksum), so yeah, I though about using modified
> instead but then decided rewritten is pretty (or even more) accurate.

Well, I was thinking less technically accurate and more descriptive for end
users, hiding the implementation details.  "Rewrite" sounds to me more like
changing data rather than amending pages with a checksum keeping data intact.
Either way, adding "in-place" is an improvement IMO.

cheers ./daniel



pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: Re: clarify "rewritten" in pg_checksums docs
Next
From: Daniel Gustafsson
Date:
Subject: Re: Online checksums patch - once again