Re: Should we back-patch SSL renegotiation fixes? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Should we back-patch SSL renegotiation fixes?
Date
Msg-id 558BF85A.5040206@iki.fi
Whole thread Raw
In response to Should we back-patch SSL renegotiation fixes?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 06/25/2015 03:03 PM, Andres Freund wrote:
> The situation is this: We have broken code using broken code. I think we
> either got to apply, darn nontrivial, fixes from
> http://archives.postgresql.org/message-id/54DE6FAF.6050005%40vmware.com
> or we got to cripple the options.
>
> It's also not the first breakage, we've applied a lot of bandaids to
> this code already. Our way of doing renegotiation also has broken
> several SSL client implementations...

Note that even with those patches, renegotiation is still broken in some 
scenarios: 
http://www.postgresql.org/message-id/54DCF736.2060207@vmware.com. As far 
as I can tell, OpenSSL's handling of renegotiation is fundamentally 
broken, and there is nothing we can do in the application to completely 
work around that.

+1 for changing the default to disable renegotiation, in all branches.

- Heikki




pgsql-hackers by date:

Previous
From: Ilya Kosmodemiansky
Date:
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Next
From: Peter Eisentraut
Date:
Subject: Re: Should we back-patch SSL renegotiation fixes?