Re: A couple of newlines missing in pg_rewind log entries - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: A couple of newlines missing in pg_rewind log entries
Date
Msg-id 558956CB.4070606@iki.fi
Whole thread Raw
In response to A couple of newlines missing in pg_rewind log entries  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 06/23/2015 07:39 AM, Michael Paquier wrote:
> Hi all,
>
> Some grepping is showing up that a couple of newlines are missing in
> pg_rewind, leading to unreadable log entries:
> libpq_fetch.c:    pg_log(PG_DEBUG, "getting file chunks");

Fixed.

> logging.c:    pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",

This one was on purpose; note the printf("\r") after that line. That's 
supposed to be a progress indicator that is updated on the single line.

> filemap.c:            pg_fatal("could not stat file \"%s\": %s",

Peter fixed this already.

- Heikki




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: pg_rewind failure by file deletion in source server
Next
From: Abhijit Menon-Sen
Date:
Subject: Re: [PATCH] introduce XLogLockBlockRangeForCleanup()