[HACKERS] Privilege checks on array coercions - Mailing list pgsql-hackers

From Tom Lane
Subject [HACKERS] Privilege checks on array coercions
Date
Msg-id 5541.1490297211@sss.pgh.pa.us
Whole thread Raw
Responses Re: [HACKERS] Privilege checks on array coercions  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
There is a test in privileges.sql (currently lines 589-625 in
privileges.out) that seems to be dependent on the fact that the
ArrayCoerceExpr logic doesn't check for EXECUTE privilege on the
per-element type coercion function if it's dealing with a NULL input
array.

While fooling with Andres' faster-expressions patch, I moved the
pg_proc_aclcheck call for this into expression compilation, causing
that privileges.sql test to fail.

Since Andres' patch moves ACL checks for regular function calls into
expression compilation, I think it would be weird and inconsistent not
to do so for ArrayCoerceExpr as well.  Does anyone want to defend this
privileges test case as testing for some behavior that users expect?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: [HACKERS] [PATCH] Move all am-related reloption code intosrc/backend/access/[am-name] and get rid of relopt_kind for custom AM
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] ICU integration