Re: src/tools/pginclude considered harmful (was Re: [PATCHES] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: src/tools/pginclude considered harmful (was Re: [PATCHES]
Date
Msg-id 5539.1152918380@sss.pgh.pa.us
Whole thread Raw
In response to Re: src/tools/pginclude considered harmful (was Re:  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> BTW, one of the remaining holes in pgrminclude is that it compiles with
>> -fsyntax-only, which apparently causes it to fail to detect some errors
>> of significance --- I assume that's how it managed to foul up lmgr.c,
>> inet_net_ntop.c, etc.

> But I do run a full compile and regression before commit, so that should
> have caught it even if pgrminclude didn't.

Doesn't catch warnings (unless you add -Werror during the build, which
will have problems with the remaining expected warnings...)
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Hiroshi Saito"
Date:
Subject: Re: [PATCHES] c.h is the problem of msvc.
Next
From: Tom Lane
Date:
Subject: Re: src/tools/pginclude considered harmful (was Re: [PATCHES]