Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
>> More to the point, this is highly incomplete... you did not teach the
>> adjacent getid routine about this, and there is code in (at least)
>> pg_dump.c that knows the quoting conventions used here.
> Hang on - those routines can parse the acls just fine? How? How do they
> handle usernames with equals signs in them (my major prob). How can it
> work at all?
IIRC, the present code assumes that usernames won't contain embedded
doublequotes. I did recently fix pg_dump to work in cases that it
wouldn't have handled before, including embedded equals. (BTW, my
mistake above: the pg_dump code is not in pg_dump.c, but in dumputils.c.
Look at copyAclUserName in particular.)
regards, tom lane
