Re: Cleaning up perl code - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Cleaning up perl code
Date
Msg-id 54d72e0f-9bb8-48d8-a31a-04401d506b07@dunslane.net
Whole thread Raw
In response to Re: Cleaning up perl code  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: Cleaning up perl code
List pgsql-hackers


On 2024-07-02 Tu 8:55 AM, Dagfinn Ilmari Mannsåker wrote:
Relatedly, I also had a look at prohibiting unused regex captures
(RegularExpressions::ProhibitUnusedCapture), which found a few real
cases, but also lots of false positives in Catalog.pm, because it
doesn't understand that %+ uses all named captures, so I won't propose a
patch for that until that's fixed upstream
(https://github.com/Perl-Critic/Perl-Critic/pull/1065).


We could mark Catalog.pm with a "## no critic (ProhibitUnusedCapture)" and then use the test elsewhere.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: On disable_cost
Next
From: Tomas Vondra
Date:
Subject: Re: Parallel CREATE INDEX for GIN indexes