[PATCH] server_version_num should be GUC_REPORT - Mailing list pgsql-hackers

From Craig Ringer
Subject [PATCH] server_version_num should be GUC_REPORT
Date
Msg-id 54AF7557.9090905@2ndquadrant.com
Whole thread Raw
Responses Re: [PATCH] server_version_num should be GUC_REPORT
List pgsql-hackers
Hi all

While looking into client code that relies on parsing server_version
instead of checking server_version_num, I was surprised to discover that
server_version_num isn't sent to the client by the server as part of the
standard set of parameters reported post-auth.

The docs reflect this:

http://www.postgresql.org/docs/current/static/protocol-flow.html#PROTOCOL-ASYNC

The attached patch marks server_version_num GUC_REPORT and documents
that it's reported to the client automatically.

(See mention here:
https://github.com/impossibl/pgjdbc-ng/commit/40b6dc658a9b38725be220e2fa653a5a8a0cbae4#commitcomment-8427979)

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Transactions involving multiple postgres foreign servers
Next
From: Noah Misch
Date:
Subject: Re: orangutan seizes up during isolation-check