Re: What in the world is happening on spoonbill? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: What in the world is happening on spoonbill?
Date
Msg-id 5494.1211053927@sss.pgh.pa.us
Whole thread Raw
In response to Re: What in the world is happening on spoonbill?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: What in the world is happening on spoonbill?  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: What in the world is happening on spoonbill?  (Peter Eisentraut <peter_e@gmx.net>)
Re: What in the world is happening on spoonbill?  (Michael Meskes <meskes@postgresql.org>)
List pgsql-hackers
I wrote:
> BTW, this exposes a pretty nasty omission in pg_regress: it fails to
> say anything about a nonzero exit code from a psql child process
> that's running a test.   Seems like wait_for_tests() ought to complain
> about that.  Any objections?

So I coded this up, and fortunately thought to try it with ecpg's tests
before committing:

test preproc/define       ... ok
test preproc/init         ... ok
test preproc/type         ... ok
test preproc/variable     ... ok
test preproc/whenever     ... FAILED: test process exited with exit code 1
test sql/array            ... ok
test sql/binary           ... ok
test sql/code100          ... ok
test sql/copystdout       ... ok

Apparently the exit(1) is intentional in that test.

We could possibly extend the syntax of regression schedule files to have
a way to say what's the expected exit status, but that seems like more
work than it's worth.  Would it be all right to just remove the test of
"on error stop" mode?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: [rfc,patch] PL/Proxy in core
Next
From: "Nicolas Barbier"
Date:
Subject: Re: Would like to sponsor implementation of MATERIALIZED VIEWS