Re: [PATCH] explain sortorder - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [PATCH] explain sortorder
Date
Msg-id 5491A299.5060904@vmware.com
Whole thread Raw
In response to Re: [PATCH] explain sortorder  (Mike Blackwell <mike.blackwell@rrd.com>)
Responses Re: [PATCH] explain sortorder  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 12/15/2014 06:49 PM, Mike Blackwell wrote:
>                     QUERY PLAN
> ------------------------------------------------
>   Sort
>     Output: n1, n2, ((n1)::character(1))
>     Sort Key: sortordertest.n1, sortordertest.n2
>     Sort Order:  ASC NULLS LAST,  ASC NULLS LAST
>     ->  Seq Scan on public.sortordertest
>           Output: n1, n2, n1
> (6 rows)

I don't like this output. If there are a lot of sort keys, it gets 
difficult to match the right ASC/DESC element to the sort key it applies 
to. (Also, there seems to be double-spaces in the list)

I would suggest just adding the information to the Sort Key line. As 
long as you don't print the modifiers when they are defaults (ASC and 
NULLS LAST), we could print the information even in non-VERBOSE mode. So 
it would look something like:

Sort Key: sortordertest.n1 NULLS FIRST, sortordertest.n2 DESC

- Heikki




pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: POLA violation with \c service=
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] explain sortorder