Re: scram and \password - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: scram and \password
Date
Msg-id 5478ab75-404f-9490-9355-dc1365ce3d7f@iki.fi
Whole thread Raw
In response to Re: [HACKERS] scram and \password  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: scram and \password  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 03/23/2017 06:41 AM, Michael Paquier wrote:
> And after a lookup the failure is here:
> -   result = get_role_password(port->user_name, &shadow_pass, logdetail);
> +   shadow_pass = get_role_password(port->user_name, logdetail);
>     if (result == STATUS_OK)
> result is never setup in this code path, so that may crash.

Ah, of course. For some reason, I has -Wno-maybe-uninitialized in my 
configure command line. Without that, gcc even warns about that.

Fixed, and pushed. Thanks!

- Heikki




pgsql-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we'rerunning as Windows serv
Next
From: Petr Jelinek
Date:
Subject: Re: Logical replication existing data copy