Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke
Date
Msg-id 54159.1559611016@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix contrib/auto_explain to not cause problems inparallel worke  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Fix contrib/auto_explain to not cause problems inparallel worke  (Michael Paquier <michael@paquier.xyz>)
List pgsql-committers
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jun 03, 2019 at 10:06:21PM +0000, Tom Lane wrote:
>> Fix contrib/auto_explain to not cause problems in parallel workers.

> This has broken the builds on Windows for 9.6 and 10:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2019-06-04%2000%3A42%3A07&stg=make

Ooops.

> This gets included as a dependency because of the call to
> IsParallelWorker() you have added in this commit, and I think that
> this can be fixed by adding PGDLLIMPORT to the variable in
> parallel.h.  Would you fix it or should I?

Yeah, I see we already did that in later branches.  I'll go fix it,
thanks for the heads-up!

            regards, tom lane



pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems inparallel worke
Next
From: Tom Lane
Date:
Subject: pgsql: Mark a few parallelism-related variables with PGDLLIMPORT.