Re: [PATCH] Filter error log statements by sqlstate - Mailing list pgsql-hackers

From Oskari Saarenmaa
Subject Re: [PATCH] Filter error log statements by sqlstate
Date
Msg-id 540A2743.3010703@ohmu.fi
Whole thread Raw
In response to Re: [PATCH] Filter error log statements by sqlstate  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
17.01.2014 19:07, Tom Lane kirjoitti:
> Oskari Saarenmaa <os@ohmu.fi> writes:
>> I don't know about others, but filtering by individual SQLSTATE is
>> exactly what I need - I don't want to suppress all plpgsql errors or
>> constraint violations, but I may want to suppress plpgsql RAISE
>> EXCEPTION and CHECK violations.

[...]

> It hasn't really been proven that SQLSTATE-class filtering would work
> conveniently, but AFAICS the only way to prove or disprove that is for
> somebody to code it up and use it in production.

[...]

> Another thought here is that if you're willing to have the filter
> only able to *prevent* logging, and not to let it *cause* logging
> of messages that would otherwise be suppressed by log_min_messages,
> it could be implemented as a loadable module using the emit_log_hook.

So this is what we ended up doing: a module with emit_log_hook to allow 
upgrading "log_min_messages" and "log_min_error_statement" values per 
sqlstate.  I'm now using this in production and it has had a positive 
impact in reducing the volume of (unwanted) logs being collected and 
allowing a kludgy rsyslog.conf filter to be removed (which didn't really 
work that well - it only dropped the first part of a multipart log 
entry, writing partial pg log entries in syslog).

https://github.com/ohmu/pgloggingfilter

I'm not super happy about the syntax it uses, but at least it should be 
obvious that it works just like the core GUCs but is settable per 
sqlstate.  I've been planning to sketch a proposal for a better way to 
configure log verbosity and details based on sqlstate, statement 
duration or other variables, but unfortunately haven't had time to do it 
yet.

/ Oskari



pgsql-hackers by date:

Previous
From: Marko Tiikkaja
Date:
Subject: Re: [PATCH] parser: optionally warn about missing AS for column and table aliases
Next
From: Pavel Stehule
Date:
Subject: Re: [PATCH] parser: optionally warn about missing AS for column and table aliases