Re: [HACKERS] Increase pltcl test coverage - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Increase pltcl test coverage
Date
Msg-id 5403.1484000586@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Increase pltcl test coverage  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
Responses Re: [HACKERS] Increase pltcl test coverage  (Jim Nasby <Jim.Nasby@BlueTreble.com>)
List pgsql-hackers
Jim Nasby <Jim.Nasby@bluetreble.com> writes:
> Got a stack trace. The abort happens in TclObjLookupVar:

Yeah, I found the problem: pltcl_returnnext calls pltcl_build_tuple_result
which may throw elog(ERROR), leaving the Tcl interpreter's state all
screwed up, so that later functions go south.  It seems quite accidental
that this is only failing with 8.4.  We need pltcl_returnnext to use a
subtransction, like the other pltcl statements that can call into generic
PG code.  Working on a fix now.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [HACKERS] WIP: [[Parallel] Shared] Hash
Next
From: David Fetter
Date:
Subject: Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATEand DELETE