Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_xlogdump --stats - Mailing list pgsql-hackers

From gotoschool6g
Subject Re: pg_xlogdump --stats
Date
Msg-id 53B68281.1080507@gmail.com
Whole thread Raw
In response to Re: pg_xlogdump --stats  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Responses Re: pg_xlogdump --stats  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Tree view
> 
> I'm pretty sure that most committers would want to apply the 
> rm_identity part in a separate commit first. Could you make it 
> two patches, one introducing rm_identity, and another with 
> xlogdump using it? 
 
Carp the code:
 
const char *
clog_identify(uint8 info)
{ 
 switch (info)
 {
      case CLOG_ZEROPAGE:
       return "ZEROPAGE";
      case CLOG_TRUNCATE:
       return "TRUNCATE";
       break;
 }
 return NULL;
}
 
or
 
const char *
clog_identify(uint8 info)
{
        if(info==CLOG_ZEROPAGE)return "ZEROPAGE";
        if(info==CLOG_TRUNCATE)return "TRUNCATE";
        return NULL;
}

is a bit faster than:
 
const char *
clog_identify(uint8 info)
{
 const char *id = NULL;
 
 switch (info)
 {
  case CLOG_ZEROPAGE:
   id = "ZEROPAGE";
   break;
  case CLOG_TRUNCATE:
   id = "TRUNCATE";
   break;
 }
 
 return id;
}
 

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: No toast table for pg_shseclabel but for pg_seclabel
Next
From: Andres Freund
Date:
Subject: Re: pg_xlogdump --stats