Re: Set new system identifier using pg_resetxlog - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: Set new system identifier using pg_resetxlog
Date
Msg-id 53ACA3D6.9080304@2ndquadrant.com
Whole thread Raw
In response to Re: Set new system identifier using pg_resetxlog  (Sawada Masahiko <sawada.mshk@gmail.com>)
Responses Re: Set new system identifier using pg_resetxlog  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Re: Set new system identifier using pg_resetxlog  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 26/06/14 19:57, Sawada Masahiko wrote:
> $ pg_resetxlog  -s0 data
> Transaction log reset
> $ pg_controldata data | grep "Database system identifier"
> Database system identifier:           6029284919152642525
>
> this patch dose not works fine with -s0.
>

Yes, this is a bug, 0 input should throw error, which it does now.

Also based on Alvaro's comment, I replaced the scanf parsing code with
strtoul(l) function.


--
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Spinlocks and compiler/memory barriers
Next
From: Vik Fearing
Date:
Subject: Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses