Postgres Pro
Downloads
Home   >   mailing lists

Re: Create function prototype as part of PG_FUNCTION_INFO_V1 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Create function prototype as part of PG_FUNCTION_INFO_V1
Date
Msg-id 534C36D9.1000803@gmx.net
Whole thread Raw
In response to Re: Create function prototype as part of PG_FUNCTION_INFO_V1  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: Create function prototype as part of PG_FUNCTION_INFO_V1  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Create function prototype as part of PG_FUNCTION_INFO_V1  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Tree view 
On 4/4/14, 10:07 AM, Andres Freund wrote:
> If
> somebody previously tried to do the correct thing and attached
> PGDLLEXPORT to their own *function* prototoype, it would cause problems
> now.

What is the difference (on affected platforms) between

Datum funcname(PG_FUNCTION_ARGS);

and writing (effectively)

PGDLLEXPORT Datum funcname(PG_FUNCTION_ARGS);
Datum funcname(PG_FUNCTION_ARGS);

or for that matter

Datum funcname(PG_FUNCTION_ARGS);
PGDLLEXPORT Datum funcname(PG_FUNCTION_ARGS);


If there isn't a difference, then my patch is fine.  Otherwise, it might
be good to document the issues for extension authors.

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Race condition between PREPARE TRANSACTION and COMMIT PREPARED (was Re: Problem with txid_snapshot_in/out() functionality)
Next
From: Fabrízio de Royes Mello
Date:
Subject: Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements