Re: pgsql: Add ANALYZE into regression tests - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Add ANALYZE into regression tests
Date
Msg-id 534A85C1.2060902@dunslane.net
Whole thread Raw
In response to pgsql: Add ANALYZE into regression tests  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Add ANALYZE into regression tests  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers
On 04/13/2014 12:42 AM, Stephen Frost wrote:
> Add ANALYZE into regression tests
>
> Looks like we can end up with different plans happening on the
> buildfarm, which breaks the regression tests when we include
> EXPLAIN output (which is done in the regression tests for
> updatable security views, to ensure that the user-defined
> function isn't pushed down to a level where it could view the
> rows before the security quals are applied).
>
> This adds in ANALYZE to hopefully make the plans consistent.
> The ANALYZE ends up changing the original plan too, so the
> update looks bigger than it really is.  The new plan looks
> perfectly valid, of course.
>
>

Are you really sure we can do this consistently? The regression tests
have to run against all sorts of settings, including those we have no
control over via installcheck.

cheers

andrew


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: pgsql: Make a dedicated AlterTblSpcStmt production
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Add ANALYZE into regression tests