Re: Bugs in TOAST handling, OID assignment and redo recovery - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Bugs in TOAST handling, OID assignment and redo recovery
Date
Msg-id 534158bd-1960-d921-ad36-ada97c2729a9@2ndquadrant.com
Whole thread Raw
In response to Bugs in TOAST handling, OID assignment and redo recovery  (Pavan Deolasee <pavan.deolasee@gmail.com>)
Responses Re: Bugs in TOAST handling, OID assignment and redo recovery
Re: Bugs in TOAST handling, OID assignment and redo recovery
List pgsql-hackers
On 4/10/18 06:29, Pavan Deolasee wrote:
> One of our 2ndQuadrant support customers recently reported a sudden rush
> of TOAST errors post a crash recovery, nearly causing an outage. Most
> errors read like this:
> 
> ERROR: unexpected chunk number 0 (expected 1) for toast value nnnn

While researching this, I found that the terminology in this code is
quite inconsistent.  It talks about chunks ids, chunk indexes, chunk
numbers, etc. seemingly interchangeably.  The above error is actually
about the chunk_seq, not about the chunk_id, as one might think.

The attached patch is my attempt to clean this up a bit.  Thoughts?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: submake-errcodes
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Problem while setting the fpw with SIGHUP