Re: Fix logging for invalid recovery timeline - Mailing list pgsql-hackers

From David Steele
Subject Re: Fix logging for invalid recovery timeline
Date
Msg-id 5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org
Whole thread Raw
In response to Re: Fix logging for invalid recovery timeline  (Benoit Lobréau <benoit.lobreau@dalibo.com>)
List pgsql-hackers
On 2/21/25 09:09, Benoit Lobréau wrote:
> On 2/20/25 4:40 PM, David Steele wrote:
>> Benoit -- this was your idea. Did you want to submit a patch yourself?
> 
> Here is an attempt at that. I kept the wording I used above. Is it fine 
> to repeat the whole ereport block twice?

I think for translation purposes this is probably how it needs to be but 
I wonder if we could do something like:

errdetail("Latest checkpoint in %s is at %X/%X <...>",
           haveBackupLabel ? "pg_control" ? "backup_label",

I'll defer to Michael on that.

In general this patch and the new messages look good to me, though.

Regards,
-David



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)
Next
From: Tender Wang
Date:
Subject: Re: generic plans and "initial" pruning