Re: Using PQexecQuery in pipeline mode produces unexpected Close messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Using PQexecQuery in pipeline mode produces unexpected Close messages
Date
Msg-id 532816.1655319402@sss.pgh.pa.us
Whole thread Raw
In response to Re: Using PQexecQuery in pipeline mode produces unexpected Close messages  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Using PQexecQuery in pipeline mode produces unexpected Close messages
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> So, git archaeology led me to this thread
> https://postgr.es/m/202106072107.d4i55hdscxqj@alvherre.pgsql
> which is why we added that message in the first place.

Um.  Good thing you looked.  I doubt we want to revert that change now.

> Alternatives:
> - Have the client not complain if it gets CloseComplete in idle state.
>   (After all, it's a pretty useless message, since we already do nothing
>   with it if we get it in BUSY state.)

ISTM the actual problem here is that we're reverting to IDLE state too
soon.  I didn't try to trace down exactly where that's happening, but
I notice that in the non-pipeline case we don't go to IDLE till we've
seen 'Z' (Sync).  Something in the pipeline logic must be jumping the
gun on that state transition.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Imseih (AWS), Sami"
Date:
Subject: [PROPOSAL] Detecting plan changes with plan_id in pg_stat_activity
Next
From: Tom Lane
Date:
Subject: Re: pg_upgrade (12->14) fails on aggregate