Re: logical decoding / rewrite map vs. maxAllocatedDescs - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: logical decoding / rewrite map vs. maxAllocatedDescs
Date
Msg-id 53047b69-9af7-1399-d190-6d7db60a7dd8@2ndquadrant.com
Whole thread Raw
In response to Re: logical decoding / rewrite map vs. maxAllocatedDescs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: logical decoding / rewrite map vs. maxAllocatedDescs
List pgsql-hackers
On 08/11/2018 04:15 PM, Tom Lane wrote:
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>>>> On 08/09/2018 07:47 PM, Alvaro Herrera wrote:
>>>>> Actually, it seems to me that ApplyLogicalMappingFile is just leaking
>>>>> the file descriptor for no good reason.
> 
>> I think the fix can be as simple as attached ... I'm mostly afk for the
>> weekend, so I'll commit & backpatch on Monday or so.
> 
> LGTM.  While you're at it, would you fix the misspelling three lines
> below this?
> 
>  * Check whether the TransactionOId 'xid' is in the pre-sorted array 'xip'.
>                                 ^
> 

Sure.

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: buildfarm: could not read block 3 in file "base/16384/2662": readonly 0 of 8192 bytes
Next
From: Fabien COELHO
Date:
Subject: Re: libpq connection timeout mismanagement