Re: logical decoding / rewrite map vs. maxAllocatedDescs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: logical decoding / rewrite map vs. maxAllocatedDescs
Date
Msg-id 6899.1533996956@sss.pgh.pa.us
Whole thread Raw
In response to Re: logical decoding / rewrite map vs. maxAllocatedDescs  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: logical decoding / rewrite map vs. maxAllocatedDescs
List pgsql-hackers
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>>> On 08/09/2018 07:47 PM, Alvaro Herrera wrote:
>>>> Actually, it seems to me that ApplyLogicalMappingFile is just leaking
>>>> the file descriptor for no good reason.

> I think the fix can be as simple as attached ... I'm mostly afk for the
> weekend, so I'll commit & backpatch on Monday or so.

LGTM.  While you're at it, would you fix the misspelling three lines
below this?

 * Check whether the TransactionOId 'xid' is in the pre-sorted array 'xip'.
                                ^

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: buildfarm: could not read block 3 in file "base/16384/2662":read only 0 of 8192 bytes
Next
From: Tomas Vondra
Date:
Subject: Re: buildfarm: could not read block 3 in file "base/16384/2662": readonly 0 of 8192 bytes