Re: narwhal and PGDLLIMPORT - Mailing list pgsql-hackers
From | Marco Atzeri |
---|---|
Subject | Re: narwhal and PGDLLIMPORT |
Date | |
Msg-id | 52FFD2E7.3030202@gmail.com Whole thread Raw |
In response to | Re: narwhal and PGDLLIMPORT (Tom Lane <tgl@sss.pgh.pa.us>) |
Responses |
Re: narwhal and PGDLLIMPORT
(Andres Freund <andres@2ndquadrant.com>)
|
List | pgsql-hackers |
On 12/02/2014 17:39, Tom Lane wrote: > Andres Freund <andres@2ndquadrant.com> writes: >> On 2014-02-12 11:26:56 -0500, Tom Lane wrote: >>> Hm. So if we're giving up on the idea of ever getting rid of PGDLLIMPORT, >>> we ought to actually remove that, so that the Cygwin build works more like >>> the other Windows builds? > >> Hm, I don't see a big advantage in detecting the errors as It won't >> hugely increase the buildfarm coverage. But --auto-import seems to >> require marking the .text sections as writable, avoiding that seems to >> be a good idea if we don't need it anymore. > > Given the rather small number of Windows machines in the buildfarm, > I'd really like them all to be on the same page about what's valid > and what isn't. Having to wait ~24 hours to find out if they're > all happy with something isn't my idea of a good time. In any case, > as long as we have discrepancies between them, I'm not going to be > entirely convinced that any of them are telling the full truth. > > I'm going to go remove that switch and see if brolga starts failing. > If it does, I'll be satisfied that we understand the issues here. > > regards, tom lane > > disabling is not working on cygwin gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard zic.o ialloc.o scheck.o localtime.o -L../../src/port -L../../src/common -Wl,--allow-multiple-definition -Wl,--disable-auto-import -L/usr/local/lib -Wl,--as-needed -lpgcommon -lpgport -lintl -lssl -lcrypto -lz -lreadline -lcrypt -o zic.exe zic.o:zic.c:(.text.startup+0xc9): undefined reference to `optarg' zic.o:zic.c:(.text.startup+0x10d): undefined reference to `optarg' /usr/lib/gcc/i686-pc-cygwin/4.8.2/../../../../i686-pc-cygwin/bin/ld: zic.o: bad reloc address 0x10d in section `.text.startup' /usr/lib/gcc/i686-pc-cygwin/4.8.2/../../../../i686-pc-cygwin/bin/ld: final link failed: Invalid operation collect2: error: ld returned 1 exit status just removing "-Wl,--disable-auto-import" and everything works $ gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard zic.o ialloc.o scheck.o localtime.o -L../../src/port -L../../src/common -Wl,--allow-multiple-definition -L/usr/local/lib -Wl,--as-needed -lpgcommon -lpgport -lintl -lssl -lcrypto -lz -lreadline -lcrypt -o zic.exe Regards Marco
pgsql-hackers by date: