Re: [PATCH] Relocation of tablespaces in pg_basebackup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Relocation of tablespaces in pg_basebackup
Date
Msg-id 52F589C7.6050804@gmx.net
Whole thread Raw
In response to Re: [PATCH] Relocation of tablespaces in pg_basebackup  (Steeve Lennmark <steevel@handeldsbanken.se>)
List pgsql-hackers
On 1/29/14, 12:07 PM, Steeve Lennmark wrote:
>         We need to think about how to handle this on platforms without
>         symlinks.
>         I don't like just printing an error message and moving on.  It
>         should be
>         either pass or fail or an option to choose between them.
> 
>     I hope someone with experience with those kind of systems can come up
>     with suggestions on how to solve that. I only run postgres on Linux.
> 
> I would still love some input on this.

Currently, pg_basebackup aborts if it has to create a symlink on a
platform that doesn't support it.  So your code that updates the
symlinks would never come into play anyway.  I'd just update that code
with a "shouldn't get here" comment and add an exit(1).




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Next
From: Jason Petersen
Date:
Subject: Re: Move unused buffers to freelist