Re: Fix linking of OpenLDAP libraries - Mailing list pgsql-hackers

From Albe Laurenz
Subject Re: Fix linking of OpenLDAP libraries
Date
Msg-id 52EF20B2E3209443BC37736D00C3C1380A33E982@EXADV1.host.magwien.gv.at
Whole thread Raw
In response to Fix linking of OpenLDAP libraries  ("Albe Laurenz" <all@adv.magwien.gv.at>)
List pgsql-hackers
Tom Lane wrote on September 04, 2006:
> "Albe Laurenz" <all@adv.magwien.gv.at> writes:
>
>>   # The backend doesn't need everything that's in LIBS, however
>> ! LIBS := $(filter-out -lz -lreadline -ledit -ltermcap -lncurses
-lcurses -lldap_r $(PTHREAD_LIBS), $(LIBS))
>
> This seems pretty risky.  What if PTHREAD_LIBS contains -L switches?
> They'd get removed even if needed for other libraries.
>
> It would probably be safer not to put LDAP into LIBS at all, but
invent
> two new macros for configure to set, say LDAP_LIBS and LDAP_LIBS_R,
> and add these to the link lines in the backend and libpq respectively.

That seems like a good idea.
I'll try to work it out and resubmit the fix.

Yours,
Laurenz Albe

pgsql-hackers by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: ECPG regression failures on OpenBSD
Next
From: Michael Meskes
Date:
Subject: Re: ECPG regression failures on OpenBSD