Re: New option for pg_basebackup, to specify a different directory for pg_xlog - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Date
Msg-id 52E71336.6090509@gmx.net
Whole thread Raw
In response to Re: New option for pg_basebackup, to specify a different directory for pg_xlog  (Haribabu kommi <haribabu.kommi@huawei.com>)
Responses Re: New option for pg_basebackup, to specify a different directory for pg_xlog  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
On 11/30/13, 6:59 AM, Haribabu kommi wrote:
> To detect provided data and xlog directories are same or not, I reused the
> Existing make_absolute_path() code as follows.

I note that initdb does not detect whether the data and xlog directories
are the same.  I think there is no point in addressing this only in
pg_basebackup.  If we want to forbid it, it should be done in initdb
foremost.

I'm not sure it's worth the trouble, but if I were to do it, I'd just
stat() the two directories and compare their inodes.  That seems much
easier and more robust than comparing path strings.




pgsql-hackers by date:

Previous
From: Murtuza Mukadam
Date:
Subject: git-review: linking commits to review discussion in git
Next
From: Robert Haas
Date:
Subject: Re: Freezing without write I/O