Questionable coding in orderedsetaggs.c - Mailing list pgsql-hackers

From Jeremy Harris
Subject Questionable coding in orderedsetaggs.c
Date
Msg-id 52E4018F.8090606@wizmail.org
Whole thread Raw
Responses Re: Questionable coding in orderedsetaggs.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
In ordered_set_startup() sorts are initialised in non-randomAccess mode
(tuplesort_begin_heap() and ~datum(), last argument).

The use of tuplesort_skip_tuples() feels very like a random access to
me.  I think it doesn't fail because the only use (and implementation)
is to skip forwards; if backwards were tried (as the interface permits)
external sorts would fail because multiple tapes are present for
FINALMERGE.
-- 
Cheers,   Jeremy



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Postgresql for cygwin - 3rd
Next
From: Tom Lane
Date:
Subject: Re: Storing pg_stat_statements query texts externally, pg_stat_statements in core