Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio
Date
Msg-id 52DC6193.5000308@2ndquadrant.com
Whole thread Raw
In response to Re: [PATCH] Fix double-inclusion of pg_config_os.h when building extensions with Visual Studio  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On 01/17/2014 07:41 PM, Magnus Hagander wrote:
> Regardless of where the other thread goes, this seems like something we
> should fix. Thus - applied, with minor changes to the comment, thanks.

Thanks.

> My understanding is that this change alone doesn't actually help us very
> much, so I haven't backpatched it anywhere. Let me know if that
> understanding was incorrect, and it would actually help as a backpatch.

I don't think there's any point backpatching it - as you say, by its
self it doesn't help tons. There's little or no evidence that anyone's
doing standalone Visual Studio based builds at the moment, and if they
are they'll have already had to define WIN32 themselves so they won't
notice.

-- Craig Ringer                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: GiST support for inet datatypes
Next
From: Maor Lipchuk
Date:
Subject: Re: Add value to error message when size extends