Re: Feature request: Logging SSL connections - Mailing list pgsql-hackers

From Dr. Andreas Kunert
Subject Re: Feature request: Logging SSL connections
Date
Msg-id 52A1D6D7.3080309@cms.hu-berlin.de
Whole thread Raw
In response to Re: Feature request: Logging SSL connections  (Marko Kreen <markokr@gmail.com>)
Responses Re: Feature request: Logging SSL connections
List pgsql-hackers
>> Anything else missing?
>
> Functionally it's fine now, but I see few style problems:
>
> - "if (port->ssl > 0)" is wrong, ->ssl is pointer.  So use just
>    "if (port->ssl)".
> - Deeper indentation would look nicer with braces.
> - There are some duplicated message, could you restructure it so that
>    each message exists only once.

New version is attached. I could add braces before and after the
ereport()-calls too, but then I need two more #ifdefs to catch the
closing braces.



--
---------------------------------------------------------------------------
                                         ____  ______  ____
Dr. Andreas Kunert                     / __/ /     / / __/
HU-Berlin, ZE Rechenzentrum (CMS)     / /_  / / / / __\\
www.hu-berlin.de/~kunert             /___/ /_/_/_/ /___/

---------------------------------------------------------------------------

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [RFC] Shouldn't we remove annoying FATAL messages from server log?
Next
From: "MauMau"
Date:
Subject: Re: Re: [RFC] Shouldn't we remove annoying FATAL messages from server log?