Re: WITHIN GROUP patch - Mailing list pgsql-hackers

From Vik Fearing
Subject Re: WITHIN GROUP patch
Date
Msg-id 52788E15.7020802@dalibo.com
Whole thread Raw
In response to Re: WITHIN GROUP patch  (Atri Sharma <atri.jiit@gmail.com>)
Responses Re: WITHIN GROUP patch
List pgsql-hackers
On 11/04/2013 08:43 AM, Atri Sharma wrote:
> Please find attached our latest version of the patch. This version
> fixes the issues pointed out by the reviewers.

No, it doesn't.  The documentation still contains formatting and
grammatical errors, and the code comments still do not match the their
surroundings.  (The use of "I" in the code comments is a point I have
conceded on IRC, but I stand by my other remarks.)

Don't bother submitting a new patch until I've posted my technical
review, but please fix these issues on your local copy.

-- 
Vik




pgsql-hackers by date:

Previous
From: "Arulappan, Arul Shaji"
Date:
Subject: Re: UTF8 national character data type support WIP patch and list of open issues.
Next
From: David Rowley
Date:
Subject: Re: logical column order and physical column order