Re: [PATCH] pg_receivexlog: fixed to work with logical segno > 0 - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: [PATCH] pg_receivexlog: fixed to work with logical segno > 0
Date
Msg-id 527763A9.3040302@vmware.com
Whole thread Raw
In response to [PATCH] pg_receivexlog: fixed to work with logical segno > 0  (Mika Eloranta <mel@ohmu.fi>)
Responses Re: [PATCH] pg_receivexlog: fixed to work with logical segno > 0
List pgsql-hackers
On 01.11.2013 11:42, Mika Eloranta wrote:
> pg_receivexlog calculated the xlog segment number incorrectly
> when started after the previous instance was interrupted.
>
> Resuming streaming only worked when the physical wal segment
> counter was zero, i.e. for the first 256 segments or so.

Oops. Fixed, thanks for the report!

It's a bit scary that this bug went unnoticed for this long; it was 
introduced quite early in the 9.3 development cycle. Seems that I did 
all the testing of streaming timeline changes with pg_receivexlog later 
in 9.3 cycle with segment numbers < 256, and no-one else have done 
long-running tests with pg_receivexlog either.

- Heikki



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: What stopped SECURITY BARRIER views from being auto-updatable?
Next
From: Andres Freund
Date:
Subject: Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?