Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Date
Msg-id 5256DBBF.8010605@dunslane.net
Whole thread Raw
In response to Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist  (Josh Kupershmidt <schmiddy@gmail.com>)
Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 09/19/2013 06:12 PM, Pavel Stehule wrote:
>
>
> 2013/9/16 Satoshi Nagayasu <snaga@uptime.jp <mailto:snaga@uptime.jp>>
>
>


>
>     I'm looking at this patch, and I have a question here.
>
>     Should "DROP TRIGGER IF EXISTS" ignore error for non-existing trigger
>     and non-existing table? Or just only for non-existing trigger?
>
>
> My opinion is so, both variants should be ignored - it should be fully 
> fault tolerant in this use case.
>
>


This thread seems to have gone cold, but I'm inclined to agree with 
Pavel. If the table doesn't exist, neither does the trigger, and the 
whole point of the 'IF EXISTS' variants is to provide the ability to 
issue DROP commands that don't fail if their target is missing.

cheers

andrew



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Auto-tuning work_mem and maintenance_work_mem
Next
From: Andrew Dunstan
Date:
Subject: Re: Auto-tuning work_mem and maintenance_work_mem