Re: Should we remove "not fast" promotion at all? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Should we remove "not fast" promotion at all?
Date
Msg-id 52125F49.5060309@vmware.com
Whole thread Raw
In response to Re: Should we remove "not fast" promotion at all?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 19.08.2013 20:27, Tom Lane wrote:
> Bruce Momjian<bruce@momjian.us>  writes:
>> On Mon, Aug 19, 2013 at 11:20:42AM +0300, Heikki Linnakangas wrote:
>>> I think "promote" file should trigger the fast promotion, and the
>>> filename to trigger the slow mode should be called
>>> "fallback_promote" or "safe_promote" or something like that. There
>>> wasn't any good reason to change the filename primarily used. It
>>> might even break people's scripts for no good reason, if people are
>>> creating the $PGDATA/promote file themselves without using pg_ctl.
>>>
>>> (I raised this back in April, but Simon argued strongly for the
>>> current situation. I never understood why.
>>> http://www.postgresql.org/message-id/517798AE.30203@vmware.com)
>
>> +1
>
> If we're going to change this in 9.3, it needs to happen *now*, as in
> the next couple hours, because I plan to wrap rc1 this afternoon.
> Please stop discussing and commit something.

Ok, committed. The promote trigger file is now called "promote", like it 
was in previous versions. For the non-fast promotion, create a file 
called "fallback_promote".

- Heikki



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgstat_reset_remove_files ignores its argument
Next
From: Tom Lane
Date:
Subject: Re: danger of stats_temp_directory = /dev/shm