Re: removing PD_ALL_VISIBLE - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: removing PD_ALL_VISIBLE
Date
Msg-id 51A8E533.5080109@agliodbs.com
Whole thread Raw
In response to Re: removing PD_ALL_VISIBLE  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: removing PD_ALL_VISIBLE  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce,

> Roberts statement was:
> 
>> Loss or corruption of a single visibility map page means possible loss
>> of half a gigabyte of data.

I fail to be alarmed at this; currently losing a single page of the clog
causes just as widespread corruption (worse, actually, since it's not
confined to one table).  It does point to the eventual need to checksum
these things, though.

> Certainly unidentified corruption of a visibility map page could easily
> cause incorrect results.  So, technically, _adding_ bits would cause
> corruption.

Yes, that's already true.  I'm pointing out that if we depend on the
vismap for all-frozen, then losing bits *also* causes corruption, so
that's something we need to test for.  Right now, there is no possible
corruption from losing bits; we simply end up scannning more pages than
we have to.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Behavior of a pg_trgm index for 2 (or < 3) character LIKE queries
Next
From: Bruce Momjian
Date:
Subject: Re: removing PD_ALL_VISIBLE